Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SBOMER-171): bugfixing operation handling #789

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

goldmann
Copy link
Contributor

@goldmann goldmann commented Oct 1, 2024

This PR fixes some inconsistencies in operation handling. Operation schema was updated, because it was wrong according to what we generate internally. Now it is allowed to not provide product config. Handling of empty config was fixed as well.

@goldmann goldmann requested a review from vibe13 October 1, 2024 15:04
@goldmann goldmann changed the title fix(SBOMER-171): ensure we can handle properly cases with empty config fix(SBOMER-171): bugfixing operation handling Oct 1, 2024
Copy link
Contributor

@vibe13 vibe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@goldmann goldmann merged commit 1fb7842 into project-ncl:main Oct 1, 2024
7 checks passed
@goldmann goldmann deleted the SBOMER-171-operation-cleanup branch October 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants